chore: remove unused angular-loader and angular-mocks dependencies#91
Closed
Kunal1522 wants to merge 1 commit intom-lab:mainfrom
Closed
chore: remove unused angular-loader and angular-mocks dependencies#91Kunal1522 wants to merge 1 commit intom-lab:mainfrom
Kunal1522 wants to merge 1 commit intom-lab:mainfrom
Conversation
Neither angular-loader nor angular-mocks are referenced anywhere in the project's HTML or JS files. - angular-loader: not used by any script tag in index.html or any language variant - angular-mocks: intended for unit tests with Karma/Jasmine, but no test files exist in this repository Closes m-lab#40
Contributor
|
Thanks for the contribution. Closing this as it is superseded by #83, which rewrites the codebase removing Angular, jQuery, Gulp, and the old We aim to merge #83 next week, which will give contributors a stable, modern base to work from. Thoughtful, targeted contributions that build on where the project is heading are much more valuable. We'd encourage you to review #83 and open any future PRs on top of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two unused dependencies from
package.jsonthat have no references anywhere in the project.Closes #40
What was removed
@bower_components/angular-loader<script>tag inindex.htmlor any language variant@bower_components/angular-mocksVerification
Searched the entire
app/directory andgulpfile.jsfor any reference to either package — no matches found:All other dependencies remain — confirmed still in active use via
<script>tags (e.g.angular-route,angular-gettext,jquery).