Restore .ts extension in HLS segment URL#39
Open
zachhide wants to merge 3 commits intom3ue:masterfrom
Open
Conversation
Restore .ts extension in HLS segment URLs generated by _rewrite_url(). The extension was originally removed to fix 404s (issue m3ue#9) when no matching route existed, but a /hls/{stream_id}/segment.ts route was later added. Without the extension, ffmpeg's HLS demuxer rejects segments with "is not in allowed_segment_extensions". Now that both routes exist, the URL generator produces /segment.ts?url=... again for full player compatibility.
fixed .TS extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore .ts extension in HLS segment URLs generated by _rewrite_url(). The extension was originally removed to fix 404s (issue #9) when no matching route existed, but a /hls/{stream_id}/segment.ts route was later added. Without the extension, ffmpeg's HLS demuxer rejects segments with "is not in allowed_segment_extensions". Now that both routes exist, the URL generator produces /segment.ts?url=... again for full player compatibility.