feat: Add PlacementOptions support to Rokt integration #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add integration start timestamp to the `PlacementOptions` object and pass it down to RoktKit - Add unit tests
|
jamesnrokt
reviewed
Jan 20, 2026
| @Nullable Map<String, WeakReference<Typeface>> fontTypefaces, | ||
| @Nullable RoktConfig config); | ||
|
|
||
| void execute(@NonNull String identifier, |
Collaborator
There was a problem hiding this comment.
Given this will end up changing in next major release is it worth calling it select placements and removing callbacks now to save the deprecation?
Additionally is it worth investigating making a dedicated interface / protocol for Rokt specific functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Rokt integration start time is not captured when the partner invokes
selectPlacements.Add
PlacementOptionsand add support forintegrationStartTimestampto pass it down to the Rokt Kit.What Has Changed
PlacementOptionsobject and pass it down to RoktKitScreenshots/Video
N/A
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)