feat: Create separate Swift target and move MPLog there #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denischilik
force-pushed
the
feat/SDKE-823-Create-separate-swift-target-and-move-SceneDelegateHandler-there-2
branch
2 times, most recently
from
c34049f to
18fdb0a
Compare
jamesnrokt
changed the title
denischilik
force-pushed
the
feat/SDKE-823-Create-separate-swift-target-and-move-SceneDelegateHandler-there-2
branch
from
ef7f2c8 to
f6a952f
Compare
- Change default_subspec from 'mParticle' to 'mParticleNoLocation' in podspec - Update Podfile platform to iOS 15.6 - Add post_install hook to ensure all pods use iOS 15.6 deployment target - Update Media SDK pod to use NoLocation subspec
- Create mParticle-Apple-SDK-Swift target - Add Swift source files and tests - Update Xcode project configuration
- Move MPLogger.swift from mParticle-Apple-SDK to mParticle-Apple-SDK-Swift - Update imports and references in Utils files - Update Xcode project configuration
- Create mParticle-Apple-SDK-Swift.podspec for Swift module - Add Swift podspec as dependency in main podspec (all subspecs) - Add Swift podspec to Example Podfile with local path
…ndencies - Copy Swift xcframework to temp_artifacts directory in build_framework() - Add mParticle_Apple_SDK_Swift.xcframework dependency to Tuist project - Update cleanup to remove both xcframeworks
denischilik
force-pushed
the
feat/SDKE-823-Create-separate-swift-target-and-move-SceneDelegateHandler-there-2
branch
from
f6a952f to
d552808
Compare
…rate-swift-target-and-move-SceneDelegateHandler-there-2
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1708,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1624,"sdk_executable_impact_bytes":896,"xcframework_size_kb":8588}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1772,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1688,"sdk_executable_impact_bytes":896,"xcframework_size_kb":8608} |
denischilik
changed the title
denischilik
requested review from
BrandonStalnaker,
jamesnrokt,
nickolas-dimitrakas and
thomson-t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Creates a separate Swift target for SceneDelegateHandler to improve code organization and enable better Swift-only module distribution. This isolates Swift-specific scene delegate handling from the Objective-C core SDK.
What Has Changed
mParticle-Apple-SDK-Swifttarget for Swift-only codeMPLogandMPILogLevelto Swift targetChecklist
Reference Issue (For employees only. Ignore if you are an outside contributor)