-
Notifications
You must be signed in to change notification settings - Fork 71
refactor: MPKitContainer pure objc #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: MPKitContainer pure objc #518
Conversation
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1752,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1668,"sdk_executable_impact_bytes":896,"xcframework_size_kb":9124}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1708,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1624,"sdk_executable_impact_bytes":896,"xcframework_size_kb":8588} |
denischilik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but keep these changes in mind for end to end testing once we have the release branch complete
4cd0f18
a3778cb
into
workstation/9.0-Release
Background
What Has Changed
MPKitContainerChecklist
Reference Issue (For employees only. Ignore if you are an outside contributor)