feat [properties] - backend soup endpoint for filter (sort coming soon) #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkweon
force-pushed
the
daniel/m-4974--feat-properties-backend-soup-endpoint-for-filter-and-sort
branch
2 times, most recently
from
e4d4c5a to
3e4f1d1
Compare
Contributor
Code reviewIssue: Missing .sqlx cache updateFile: The SQL query was modified (changing According to the CLAUDE.md:
Resolution: Run |
- Add property_filters field to SoupRequest and SimpleSortRequest - Extract property_filters in router before converting to EntityFilterAst - Route to dynamic query when property_filters is not empty - Build EXISTS subqueries for each property filter per entity type Note: Frecency sort does not yet apply property filters.
- Optimize HasAll to use single @> check with array of all values instead of multiple AND checks for better performance - Remove unused apply_filter function (not used in production) - Remove redundant test_sql_apply_filter_uses_default_alias test - Add push_has_all_check function for efficient HasAll queries
danielkweon
force-pushed
the
daniel/m-4974--feat-properties-backend-soup-endpoint-for-filter-and-sort
branch
from
3e4f1d1 to
9ce18a5
Compare
| d."fileType" as file_type, | ||
| d.owner as "owner!", | ||
| d."updatedAt"::timestamptz as "updated_at", | ||
| d."updatedAt"::timestamptz as "updated_at!", |
Member
There was a problem hiding this comment.
oh weird, does this not require a regen of the queries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat [properties] - backend soup endpoint for filter (sort coming soon)