Conversation
|
Can we update the title of the PR to accurately reflect the changes here? :)) |
spikeburton
approved these changes
Jul 7, 2025
ispasov
force-pushed
the
is/deploy-attempts
branch
from
3b0e9ce to
87c7c76
Compare
Allow env vars to either be set with or without CUSTOM_ENV_ prefix. The prefix is added automatically by GitLab if the var is set from the UI. If the variable is set from the container, it is not prefixed. Both approaches are valid so support both.
ispasov
force-pushed
the
is/env-vars-improvements
branch
from
c1af185 to
a54e354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow env vars to either be set with or without CUSTOM_ENV_ prefix.
The prefix is added automatically by GitLab if the var is set from the UI.
If the variable is set from the container, it is not prefixed.
Both approaches are valid so support both.
Testing
Contact me for more information