Fix DelegateSpeedTest not running in all localisations#36
Open
rklec wants to merge 1 commit intomadhatter22:masterfrom
Open
Fix DelegateSpeedTest not running in all localisations#36rklec wants to merge 1 commit intomadhatter22:masterfrom
rklec wants to merge 1 commit intomadhatter22:masterfrom
Conversation
As `,` is a thousand separator (only) in (US) English or so, this test would fail in other localizations such as German with an exception while parsing.
Author
|
Oh, and please note this could (have skewed) the performance benchmarks, as it may have been parsed at each iteration (Actually not sure, but well at least once)? Now the looping is not parsed anymore. |
rklec
changed the title
rklec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
,is a thousand separator (only) in (US) English or so, this test would fail in other localizations such as German with an exception while parsing.AFAIK this is how you usually separate that in C# without having to resort to parsing static strings.