Modernize ConnectionFactoryBase.cs#45
Open
rklec wants to merge 1 commit intomadhatter22:feature/drop-support-pre-netstandard2.0from
Open
Modernize ConnectionFactoryBase.cs#45rklec wants to merge 1 commit intomadhatter22:feature/drop-support-pre-netstandard2.0from
rklec wants to merge 1 commit intomadhatter22:feature/drop-support-pre-netstandard2.0from
Conversation
* use nullable assertion, you may probably want to set `<Nullable>enable</Nullable>` in your project https://learn.microsoft.com/en-us/dotnet/csharp/nullable-migration-strategies * merged many things into a pattern, see https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/patterns (suggested by Resharper) * use new switch expression https://learn.microsoft.com/en-US/dotnet/csharp/language-reference/operators/switch-expression Note zthe constructor of `ConnectionFactoryBase` is still quite heavy and does a lot of things. I've left it for now, but maybe needs adjustments. Also you may want to use https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces for the whole project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Nullable>enable</Nullable>in your project https://learn.microsoft.com/en-us/dotnet/csharp/nullable-migration-strategiesNote the constructor of
ConnectionFactoryBaseis still quite heavy and does a lot of things. I've left it for now, but maybe needs adjustments. Also you may want to use https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces for the whole project.