Improve message sending #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
better-message
branch
from
1860013 to
490bb35
Compare
Also cuts down on the hoops we have to jump through from msg_send to reach the actual message sending
In Objective-C, having a null pointer receiver is valid, but with `msg_send!` it would be converted into a reference, which is undefined behavior. The reference was converted into a pointer immediately after, but it is still UB. There might also be a mutable reference somewhere else in the program, which would now be aliased. With this, we can now stop de-referencing the receiver of msg_send!, and still have Id work ergonomically. However, null pointer receivers are still discouraged because of all the other issues they cause! This change additionally allows sending messages to NonNull<T>, Option<&[mut] T> and Option<NonNull<T>>.
This makes the syntax match Rust expectations a bit closer IMO
Rustfmt can't do this for us
madsmtm
force-pushed
the
better-message
branch
from
490bb35 to
6d7ddbc
Compare
We actually don't want to encourage sending messages to nil objects, since that is only supported for selectors that return pointers
madsmtm
force-pushed
the
better-message
branch
from
e9b0236 to
1b62354
Compare
madsmtm
force-pushed
the
better-message
branch
from
4e9cd30 to
18b26ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msg_send!(replaces Stop dereferencingmsg_send!'s first argument SSheldon/rust-objc#102 and Manually dereferenceIdSSheldon/rust-objc-foundation#14)MessageReceiver, and moveMessagemethods to that, to alleviate the issues in Stop dereferencingmsg_send!'s first argument SSheldon/rust-objc#102 and allowing sending messages toNonNull<T>.