Shortcodes should return a value not output/echo#130
Open
aaronware wants to merge 1 commit intomaevelander:masterfrom
Open
Shortcodes should return a value not output/echo#130aaronware wants to merge 1 commit intomaevelander:masterfrom
aaronware wants to merge 1 commit intomaevelander:masterfrom
Conversation
require will output by default. Previous implementation results in broken pages within the REST API if the shortcode is used.
|
Fixes #133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require()will print the output of the included file's content by default even if returning as a value. Previous implementation results in broken result json response for any pages of the site that used the[kbe_knowledgebase]shortcode within their content when referenced using the REST API.