A way to get back to normal video speed#120
Open
Yhozen wants to merge 4 commits intomafintosh:masterfrom
Open
Conversation
dawsbot
reviewed
Feb 27, 2017
| var time = formatTime(percentage * media.duration) | ||
| tooltip.innerHTML = time | ||
| tooltip.style.left = (e.pageX - tooltip.offsetWidth / 2) + "px" | ||
| tooltip.style.left = (e.pageX - tooltip.offsetWidth / 2) + 'px' |
There was a problem hiding this comment.
There are a few linting changes in this diff that seem unnecessary, can these be removed, so it's only a functionality PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem that I see is when you change the speed you can't make it "normal" again, so I thought that Double-click in the icon (actually in any part of the div) would be a good idea