Expand allowed versions of MySQL/MariaDB #189
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This integrates the idea and work of https://github.com/Sental/db-override into the Mage-OS core.
Currently if you try to install Mage-OS on, say, MariaDB 10.11, you'll get an error. It's perfectly compatible, but Magento errs on the side of caution and only allows installation with specific known supported versions/DB engines: MySQL 5.7, 8.0; MariaDB 10.4, 10.5, 10.6, 11.4.
This expands the supported versions to include MySQL 8.1, and all MariaDB 10.2-10.11 and 11.x.
I added the new rules separately so that they shouldn't cause merge conflicts with changes to Magento's supported DB rules upstream.
Related Pull Requests
-
Fixed Issues (if relevant)
-
Manual testing scenarios (*)
setup:install, without the patch. Get error.setup:install, with the patch. Install successfully.Questions or comments
The unit test for the related class is unaffected, still runs cleanly.
Contribution checklist (*)