Skip to content

Conversation

@MaksyKun
Copy link
Contributor

@MaksyKun MaksyKun commented Sep 7, 2025

  • Added a condition line to seperate costs and conditions in the GUI
  • Added an option to hide all itemflags on the icon by providing flags: *
  • Added an option to disable vanilla recipes under config.yml
  • Added an option to auto join professions under config.yml
  • Fixed some hashing on the ingredients while crafting (There was a bug where visually all looked fine, but internally the items didnt match)
  • Fixed some event services (joining, leaving) for persistent db storage

@MaksyKun MaksyKun requested a review from Travja September 7, 2025 07:23
@MaksyKun
Copy link
Contributor Author

@copilot
I'm facing an issue which needs to be fixed before this PR is ready to go:

In times it happens that queued Items of players keep disappearing on disconnecting or changing servers. This leads to a data loss in terms of longer taking recipes with crafting cooldown.

I have checked the code myself and made sure that FusionQueuesSQL.java has the only spot public boolean removeQueueItem(QueueItem item) { on line 92 on which items can be directly removed from the database.

Please figure out how being offline is possible to make such an impossible data leak and how it could be solved, thank you.

@MaksyKun MaksyKun marked this pull request as draft September 17, 2025 20:51
@MaksyKun
Copy link
Contributor Author

@copilot Please make sure to work on the comment above

@MaksyKun MaksyKun assigned MaksyKun and unassigned Copilot Sep 17, 2025
@MaksyKun MaksyKun marked this pull request as ready for review September 17, 2025 21:39
@Travja Travja merged commit cc5aae8 into dev Oct 26, 2025
1 check passed
Travja added a commit that referenced this pull request Oct 31, 2025
* added * for itemflag hiding in settings item

* added * for itemflag hiding in settings item

* added mechanic to disable bukkit recipes

* added condition line next to requirement line to define what will be taken and what is just a condition at all

* added auto-joining

* fixed some event services for joining/leaving professions

* removed debug

* fixed ingredient hash on craft method

* Formatting

* fixed categories not being openable when registered in the gui

* remove latest gui on leave

* caching money to reduce lags through db-connections

* added debug for issue handling with queue data loss on rejoining

* fixed queue data loss with properly configured primary keys

* removed debug

* fixed skull meta on queued items

---------

Co-authored-by: Travja <the.only.t.craft@gmail.com>
Travja added a commit that referenced this pull request Nov 1, 2025
* added * for itemflag hiding in settings item

* added * for itemflag hiding in settings item

* added mechanic to disable bukkit recipes

* added condition line next to requirement line to define what will be taken and what is just a condition at all

* added auto-joining

* fixed some event services for joining/leaving professions

* removed debug

* fixed ingredient hash on craft method

* Formatting

* fixed categories not being openable when registered in the gui

* remove latest gui on leave

* caching money to reduce lags through db-connections

* added debug for issue handling with queue data loss on rejoining

* fixed queue data loss with properly configured primary keys

* removed debug

* fixed skull meta on queued items

---------

Co-authored-by: Travja <the.only.t.craft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants