fix: revert cache replenish retries

[bmuddha]

Summary by CodeRabbit

• Refactor
  • Simplified internal control flow for program cache handling. Error behavior remains consistent with no impact to end-user functionality.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request simplifies the retry logic around replenish_program_cache in src/transaction_processor.rs by removing the retry loop, replenish_retried state, and cache prune/reset path. Direct invocation replaces the retry mechanism while maintaining consistent error handling.

Changes

Cohort / File(s)	Change Summary
Program cache replenishment logic simplification src/transaction_processor.rs	Replaced retry loop around replenish_program_cache with direct invocation; removed replenish_retried state and cache prune/reset path; error handling and ProgramCacheHitMaxLimit observable outputs remain unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single file modification focused on control flow simplification
• Removal of retry/rollback logic is straightforward to verify
• Ensure error paths produce equivalent behavior and that eliminating the retry mechanism does not inadvertently affect program cache behavior

Possibly related PRs

• fix: re-attempt to replenish the program cache on error #8 — Directly modifies retry logic around replenish_program_cache in the same function; one removes the retry/rollback path while the other adds a retry/prune-on-first-failure approach.
• fix: completely prune the program cache when cache limit is hit #9 — Modifies program-cache retry/prune logic in src/transaction_processor.rs; the main PR removes the retry/rollback and prune/reset path while this PR alters the prune call on that path.

Suggested reviewers

• GabrielePicco

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'fix: revert cache replenish retries' directly and accurately describes the main change: removing retry logic from the cache replenish function.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bmuddha/fix/revert-cache-replenish-retries

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4878759 and 3e9456e.

📒 Files selected for processing (1)

• src/transaction_processor.rs (1 hunks)

🔇 Additional comments (1)

src/transaction_processor.rs (1)

370-391: Behavioral change: Removed retry mechanism for program cache replenishment.

The retry loop that previously attempted to prune and reload the cache when hitting max limit has been removed. Now, if replenish_program_cache returns hit_max_limit, all transactions in the batch immediately fail with ProgramCacheHitMaxLimit without any recovery attempt.

Impact:

• Transactions may fail more frequently when the program cache is at capacity
• Simplifies the code by removing retry/prune complexity
• May result in different behavior under high cache pressure

Please confirm:

• This behavioral change is intentional and addresses specific issues with the retry mechanism
• Any relevant stakeholders are aware of the potential increase in transaction failures when cache is full
• Consider whether metrics or logging should track ProgramCacheHitMaxLimit errors to monitor the impact

The code logic itself is correct—the measure_us! macro properly wraps the block, and the early return on hit_max_limit works as intended.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[GabrielePicco]

LGTM!