Skip to content

Comments

chore: allow deprecated items in lib.rs#13

Merged
thlorenz merged 2 commits intomainfrom
thlorenz/fix-deprecations
Feb 2, 2026
Merged

chore: allow deprecated items in lib.rs#13
thlorenz merged 2 commits intomainfrom
thlorenz/fix-deprecations

Conversation

@thlorenz
Copy link
Contributor

@thlorenz thlorenz commented Feb 2, 2026

Summary

Allow deprecated items in lib.rs to minimize modifications to the upstream crate and facilitate merging of upstream changes without needing to fix deprecation warnings.

Details

Added #![allow(deprecated)] attribute with a comment explaining the rationale: we want to keep changes to this crate minimal to be able to cleanly merge upstream changes in the future.

Summary by CodeRabbit

  • Chores
    • Internal housekeeping to reduce deprecation warning noise and improve code clarity; no changes to functionality, public APIs, or user experience.

@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

Walkthrough

Added a crate-level attribute #![allow(deprecated)] and an explanatory comment to src/lib.rs. No control-flow, behavioral, or public API changes.

Changes

Cohort / File(s) Summary
Crate attribute and comment
src/lib.rs
Inserted #![allow(deprecated)] and a brief explanatory comment; three lines added, no functional or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: allow deprecated items in lib.rs' accurately describes the main change: adding a crate-level attribute to suppress deprecation warnings in the library file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch thlorenz/fix-deprecations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thlorenz thlorenz requested a review from bmuddha February 2, 2026 09:21
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@src/lib.rs`:
- Line 5: Replace the crate-wide attribute "#![allow(deprecated)]" in lib.rs
with targeted suppression: remove the top-level attribute and instead add
#[allow(deprecated)] only on the specific modules, functions, or items that
actually call deprecated APIs (e.g., annotate the module declarations or
individual functions that reference deprecated types/traits). Also add a short
comment next to each targeted #[allow(deprecated)] explaining which deprecated
symbol is used and a TODO to track migration, so deprecated usage remains
visible and reviewable.
- Around line 3-4: The file-level comment contains a typo: change "ordr" to
"order" in the crate comment string at the top of src/lib.rs (the two-line
comment starting with "We don't want to modify this crate..."). Edit that
comment to read "So we don't fix deprecated items here in order to be able to
merge upstream changes." to correct the spelling.

Copy link
Collaborator

@bmuddha bmuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thlorenz thlorenz merged commit cf97eae into main Feb 2, 2026
2 checks passed
@thlorenz thlorenz deleted the thlorenz/fix-deprecations branch February 2, 2026 10:16
thlorenz added a commit that referenced this pull request Feb 2, 2026
* main:
  chore: allow deprecated items in lib.rs (#13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants