Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019c1da5-f037-7155-9315-dc0eb0bfc7af Co-authored-by: Amp <amp@ampcode.com>
WalkthroughAdded a crate-level attribute Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/lib.rs`:
- Line 5: Replace the crate-wide attribute "#![allow(deprecated)]" in lib.rs
with targeted suppression: remove the top-level attribute and instead add
#[allow(deprecated)] only on the specific modules, functions, or items that
actually call deprecated APIs (e.g., annotate the module declarations or
individual functions that reference deprecated types/traits). Also add a short
comment next to each targeted #[allow(deprecated)] explaining which deprecated
symbol is used and a TODO to track migration, so deprecated usage remains
visible and reviewable.
- Around line 3-4: The file-level comment contains a typo: change "ordr" to
"order" in the crate comment string at the top of src/lib.rs (the two-line
comment starting with "We don't want to modify this crate..."). Edit that
comment to read "So we don't fix deprecated items here in order to be able to
merge upstream changes." to correct the spelling.
Amp-Thread-ID: https://ampcode.com/threads/T-019c1dd7-784c-7081-b4c9-68614bb97dce Co-authored-by: Amp <amp@ampcode.com>
thlorenz
added a commit
that referenced
this pull request
Feb 2, 2026
* main: chore: allow deprecated items in lib.rs (#13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow deprecated items in lib.rs to minimize modifications to the upstream crate and facilitate merging of upstream changes without needing to fix deprecation warnings.
Details
Added
#![allow(deprecated)]attribute with a comment explaining the rationale: we want to keep changes to this crate minimal to be able to cleanly merge upstream changes in the future.Summary by CodeRabbit