Adds support for local FastCGI and logging #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non backwards compat
expose waitgroup.Wait so shutdown handlers can wait on the server
Revert "expose waitgroup.Wait so shutdown handlers can wait on the serve...
Fix missing TLS state
…ogger and the nice API for signal handling.
…ve been added to prevent obviously-meaningless usage.
added 2 commits
October 12, 2016 19:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local FastCGI is needed when a Go webserver must co-exist with an existing server, e.g. Nginx. This avoids problems with TCP port sharing and provides a fast-performing connection between services on a server.
(Remote FastCGI is not really needed because TCP covers this case.)
Also, simple logging of the Manners actions is implemented. A pluggable logger is used.