Extract a "filer" interface for listeners #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manners currently has a type switch that it uses to get a file descriptor from various types of listeners:
netpackage which have aFile() (*os.File, error)method.netlistener types.This pull request defines a
filerinterface which is implemented by all currently supportednetlisteners. It also two internally defined listener types to implement this interface.Aside from being a cute way to use Go's type system, this makes it possible for external packages to pass in custom
net.Listenerimplementations as long as they have an appropriateFile()method. As before, listeners which do not will experience failures when callingGetFile()on aGracefulListener.Two possibilities I chose not to pursue because of their broader implications for the Manners interface:
GracefulListenerimplement thefilerinterface itself by aliasingGetFile()asFile().GracefulListeneronly acceptnet.Listeners which also implementfiler(probably by making thefilerinterface an explicit superset ofnet.Listener).