Open
Conversation
*mainwp-key-maker.php* - Added the same "Requires at least" of MainWP Dashboard. - Because "Requires at least" is below 4.6. we need to set a Text Domain in mainwp-key-maker.php and it needs to be mainwp-key-maker to correctly internationalize the plugin. (More info: https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains) - Setting a License header is mandatory for new plugins since April 2020. Consider adding one, preferably the same one as WordPress itself: “GPLv2 or later” (More info: https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/#1-plugins-must-be-compatible-with-the-gnu-general-public-license) *readme.txt* - Added "Tested up to: 5.4". We can limit the "Tested up to:" to just the major release (e.g. 5.4). The repository will automatically add the latest minor version as plugins shouldn’t break with a minor update.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



mainwp-key-maker.php
readme.txt