Skip to content

Conversation

@Vignesh-Thangamariappan

Ref: #690

Vignesh added 2 commits January 12, 2021 15:29
Updated the Region initialiser as firstWeekday is getting reset on setting the locale
@ExtremeMan
Copy link

@malcommac this seems like a valid fix for a valid bug. Can we merge it? @Vignesh-Thangamariappan can you rebase?

@ExtremeMan
Copy link

ExtremeMan commented Nov 17, 2022

Or return back this method? 4.5.1...5.0.0#diff-4ddb0e769834923d6d637cfe9c9974c5d6d2c0e17c1703ac9ec3b7eaae5f68a9L89-L96

	/// Identify the first weekday of the calendar.
	/// By default is `sunday`.
	public var firstWeekday: WeekDay {
		set {
			self.calendar.firstWeekday = newValue.rawValue
		}
		get {
			return WeekDay(rawValue: self.calendar.firstWeekday)!
		}
	}

@Vignesh-Thangamariappan
Copy link
Author

Sure @ExtremeMan
I'm on it

@Vignesh-Thangamariappan
Copy link
Author

@malcommac Can you please review and merge these changes. Would be helpful for people facing #690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants