Remove zero bytes after diff and extra data #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbsdiff seems to write one extra zero byte for every byte in the target binary to the compressed stream. While these are mostly compressed away, it will still make the patches slightly smaller and the patching slightly faster to not write them. This should make jbsdiff's patches more similar to those generated by bsdiff. However, even after this change, both library seem to generate slighly different patch files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jbsdiff seems to write one extra zero byte for every byte in the
target binary to the compressed stream. While these are mostly
compressed away (and not consumed by bspatch or jbsdiff patch),
it will still make the patches slightly smaller and the patching
slightly faster to not write them.
This should make jbsdiff's patches more similar to those generated
by bsdiff. However, even after this change, both library seem
to generate slighly different patch files.