qml: Don't break the emoji keyboard if LocalStorage fails#238
Open
pslldq wants to merge 1 commit intomaliit:masterfrom
Open
qml: Don't break the emoji keyboard if LocalStorage fails#238pslldq wants to merge 1 commit intomaliit:masterfrom
pslldq wants to merge 1 commit intomaliit:masterfrom
Conversation
Some conditions (like missing access rights to create the database path) may lead the LocalStorage.openDatabaseSync call to fail. This causes the db variable to point to an undefined value, which breaks generating and displaying the list of emojis. Instead of handling the failed database at every usage, simply provide a bare minimum dummy implementation that doesn't store anything and just returns empty query results. This allows the rest of the code to stay the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some conditions (like missing access rights to create the database path) may lead the LocalStorage.openDatabaseSync call to fail. This causes the db variable to point to an undefined value, which breaks generating and displaying the list of emojis.
Instead of handling the failed database at every usage, simply provide a bare minimum dummy implementation that doesn't store anything and just returns empty query results. This allows the rest of the code to stay the same.