Skip to content

Conversation

@Traxmaxx
Copy link
Contributor

@Traxmaxx Traxmaxx commented Apr 8, 2014

Finally made it to have a look at the scroll caching : )

Just a small improvement: you're now able to give your list a custom id through viewParams

@Traxmaxx
Copy link
Contributor Author

Traxmaxx commented Apr 8, 2014

Added another commit to be able to reset the scroll position. I'm not really happy messing around with the users scope though. Maybe you have a better idea? : )

@Traxmaxx
Copy link
Contributor Author

Traxmaxx commented Apr 8, 2014

Tests are fixed. Unfortunately he's only running 2 of them.

Running "karma:continuous" (karma) task
INFO [reporter.osx]: OSX Notification Center reporter started at http://localhost:1337
INFO [karma]: Karma v0.10.10 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
WARN [watcher]: Pattern "/Users/traxmaxx/angular-ui-table-view/bower_components/iscroll/build/iscroll-probe.js" does not match any file.
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket A9UfF0wzcg7Ejgxs12ts
LOG: 'Restoring', 0
LOG: 'Restoring', 0
.
LOG: 'Restoring', 0
LOG: 'Restoring', 0
.
PhantomJS 1.9.7 (Mac OS X): Executed 2 of 2 SUCCESS (0.132 secs / 0.002 secs)

Done, without errors.

Is this correct? Can I remove iScroll from karma.conf.js?

@wedgybo
Copy link
Member

wedgybo commented Apr 8, 2014

Ahh yea iScroll can be taken out now. Sorry will look over this properly shortly.

humancopy and others added 2 commits April 12, 2014 13:02
Adds the main files definition (useful when using tools such as bower-install)
@Traxmaxx
Copy link
Contributor Author

Any update on my thoughts? : )

@wedgybo
Copy link
Member

wedgybo commented Apr 23, 2014

Hi Alex, Sorry I've been away over easter and am just catching up with this now!

Yes these make sense!

I am looking at this along with one of the guys at Ionic, so there's a chance my thoughts could change. As they make use of services and delegates to control this sort of thing which could be the way forward.

@Traxmaxx
Copy link
Contributor Author

No worries : ) Is there a thread or issue where I can follow the discussion?

@wedgybo
Copy link
Member

wedgybo commented Apr 30, 2014

It wasn't much and it was by email @Traxmaxx. They actually just released their version of a virtular scroller in beta2 of the ionic framework. I had a quick play with it and it looks pretty awesome.

@Traxmaxx
Copy link
Contributor Author

Ah, ok. Got the scroll caching working successfully yesterday with our app. I did many manual fixes currently and needed to add some of the changes from master. I'll try to make a pull-request asap.

@Traxmaxx
Copy link
Contributor Author

Traxmaxx commented May 2, 2014

There you go : )

@Traxmaxx Traxmaxx changed the title Look for a distinct listId in viewParams Save and restore scroll-position for multiple lists May 2, 2014
@DeepAnchor
Copy link
Contributor

@Traxmaxx very cool, looking forward to the merge!

@wedgybo
Copy link
Member

wedgybo commented May 13, 2014

Right, back in the game. Lets take a look at this 💃

@Traxmaxx
Copy link
Contributor Author

\o/

@Traxmaxx
Copy link
Contributor Author

So, what's the status? Should I take care of merging the fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants