-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ibm5170.xml - Add a few SPCS games #14534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hash/ibm5170.xml
Outdated
| </part> | ||
| </software> | ||
|
|
||
| <software name="alfonstra" supported="no"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a reason about why supported="no", preferably in a notes field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disks work now as I've converted them to IMD. They are 82-track disks which caused mame to fail in parsing them. I've added a note about this.
d2e7fae to
be6f074
Compare
hash/ibm5170.xml
Outdated
| </software> | ||
|
|
||
| <software name="alfonspl"> | ||
| <description>Alfons påhittelåda (Swedish)</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description tags should be by country not by language i.e. Sweden rather than Swedish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the other entries do, hence I did it this way. Should I change this to Sweden, keep it consistent and use Swedish, or update all entries? The last one would require some effort and probably should be a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only pcdos2ksv that has the Swedish wrong tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at the other languages as well, like German.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's out of scope for this PR yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be solved now.
New working software list items (ibm5170.xml)
Alfons påhittelåda (Sweden) [FakeShemp]
Cheops pyramid (Sweden) [conradtrout @ archive.org]
Handla med Alfons (Sweden) [FakeShemp]
Måla med Alfons (Sweden) [Max lundell @ archive.org]
Mitt första datorprogram (Sweden) [retrotrollet @ archive.org]
Pussla med Alfons (Sweden) [Max lundell @ archive.org]
Alfons på äventyr i trafiken (Swedish) [Max lundell @ archive.org]
Kom till Alfons hemliga kalas (Sweden) [Max lundell @ archive.org]