Skip to content

Conversation

@manjugv
Copy link
Owner

@manjugv manjugv commented Feb 5, 2020

Addressing openshmem-org#180

@manjugv
Copy link
Owner Author

manjugv commented Feb 5, 2020

@agrippa @minsii @swpoole @jamesaross @tonycurtis Can you please review?

@agrippa
Copy link

agrippa commented Feb 5, 2020

I agree with the sentiment in the original issue: users shouldn't be relying on collective memory allocation/deallocation for quieting memory operations. In that case, I think that allocating routines (calloc, malloc, realloc) should have a shmem_sync_all at exit. De-allocating routines (free, realloc) should have a shmem_barrier_all at entry?

However, if there are hypothetical programs out that there that do rely on that property (intentionally or otherwise) this is a change that breaks those programs because they change OpenSHMEM semantics. So I think we need to discuss whether this should be handled in the committee.

@agrippa
Copy link

agrippa commented Feb 5, 2020

Just making a note here. The current semantics are a shmem_barrier_all on exit for allocating routines and a shmem_barrier_all on entry for de-allocating routines.

I also think we might need changes to the new shmem_malloc_with_hints?

@manjugv
Copy link
Owner Author

manjugv commented Feb 10, 2020

Will address this as a part of OpenSHMEM 1.6

manjugv pushed a commit that referenced this pull request Oct 26, 2020
Clarify element sizes for collectives
manjugv pushed a commit that referenced this pull request Oct 26, 2020
Convert \hyperref on non-identifiers to \ref
manjugv pushed a commit that referenced this pull request Oct 26, 2020
manjugv pushed a commit that referenced this pull request Oct 26, 2020
Specify deprecated p2p types for `shmem_wait_until` and `shmem_test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants