Allow invalid value for amount#72
Merged
manuelbl merged 2 commits intomanuelbl:masterfrom May 12, 2025
Merged
Conversation
…d amount value (currently only "NULL" / "null")
Owner
|
Thanks for the PR. It looks good at first sight. The unit tests are currently failing, likely due to outdated packages and other incompatibilities with the CI pipeline. These should all have been sorted out this weekend with another PR. Can you thus rebase your PR onto the main branch? You might want to undo the changes |
…s-valid-amount-value # Conflicts: # CoreTest/CoreTest.csproj
Contributor
Author
|
I have updated the branch and all tests are running successfully locally. |
Owner
|
Thanks for the PR. I've merged it. I will likely include it in release 3.3.1, which I plan to release by the end of the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QRBill.DecodeQrCodeTextto allow invalid amount value (currently only "NULL" / "null")