Skip to content

Adding support for entry_file #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucasstorti wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding support for entry_file #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a45aae
Adding entryFile as one of the options for code_push_release_react_ac…
Apr 15, 2019
c3eb0e6
Fixing read me
Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ target_binary_version | Target binary version for example 1.0.1 | |
mandatory | manadtory update or not | | true
description | Release description for CodePush | | no description for release
no_duplicate_release_error | Specifies whether to return an error if the main bundle is identical to the latest codepush release | | false
entry_file | This specifies the relative path to the app's root/entry JavaScript file. | | none
dry_run | Print the command that would be run, but don't run it | | false

### Release React action
Expand Down
9 changes: 8 additions & 1 deletion lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ def self.run(params)
if params[:sourcemap_output]
command += "-s #{params[:sourcemap_output]} "
end
if params[:entry_file]
command += "-e #{params[:entry_file]} "
end
if params[:dry_run]
UI.message("Dry run!".red + " Would have run: " + command + "\n")
else
Expand Down Expand Up @@ -112,7 +115,11 @@ def self.available_options
FastlaneCore::ConfigItem.new(key: :sourcemap_output,
is_string: true,
optional: true,
description: "Specifies path to write sourcemap to")
description: "Specifies path to write sourcemap to"),
FastlaneCore::ConfigItem.new(key: :entry_file,
is_string: true,
optional: true,
description: "Specifies the relative path to the app's root/entry JavaScript file")
]
end

Expand Down