Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Conversation

@Local9
Copy link
Collaborator

@Local9 Local9 commented May 19, 2023

  • Fix issue with Substring error
  • Updated version for NuGet Deployment
  • Added 'ref' .dlls from CFX FiveM Client and Server (we don't share the same hard drives)

Currently have an issue where events sent from the client are not showing any activity on the server console, this requires more investigation but currently builds are working so it can be tested.

Client:
image

Server:
image

ignore the MySql.Data error, its not related to the current issue and doesn't stop the resource from working

@Local9
Copy link
Collaborator Author

Local9 commented May 19, 2023

Personally not a fan of the Substring use, if there is a better way to get the handle I'd rather do that as we should try to deal with possible changes to the Remote class. Maybe @thorium-cfx could provide some insight or take a look, most likely will go "WTF are you doing?!" and provide a better solution.

@thorium-cfx
Copy link

thorium-cfx commented May 20, 2023

as we should try to deal with possible changes to the Remote class

Remote type will probably get more functionality added, not removed. But you're always free to convert them into a Player or bool type, those interfaces stay the same. And like my comment above Dynfunc already converts these for you.

most likely will go "WTF are you doing?!" and provide a better solution.

😏

Local9 added 14 commits May 20, 2023 09:44
Have I understood this correctly? The invoke needs to be changed.

```cs
DynFunc dynFunc = Func.Create<T,R>(MyFunc);
dynFunc(remote, arg1, arg2, arg2); // which is the same as:
dynFunc(remote, new object[] { arg1, arg2, arg2 });

Delegate dele = dynFunc;
dele.DynamicInvoke(arg1, arg2, arg3); // calls: dynFunc(arg1, arg2, arg3); which is wrong
dele.DynamicInvoke(remote, new object[] { arg1, arg2, arg3 }); // calls: dynFunc(remote, new object[] { arg1, arg2, arg3 }); which is correct, but slow
```
- Send Remote down from the Event Handlers due to use of DynFunc
- Client doesn't know what a Player is? maybe I'm missing something?
- Client doesn't get information back but the method on the server is invoked, still there is a arguments issue which needs to be addressed.
@Local9
Copy link
Collaborator Author

Local9 commented May 29, 2023

Will install RedM tomorrow and do some RedM testing too.

@Local9 Local9 changed the title testing: updates from initial testing Mono V2 Testing Sep 3, 2023
@Local9 Local9 added enhancement New feature or request on hold PR is on hold labels Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request on hold PR is on hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants