Trade Penalty #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need depth... I saw a piececount in bitboard
//Apply trade penalty if not very winning or losing. //TODO: Try only if Allie losing
Owner
|
I think this should be done in Node::setQValueFromRaw by modifying the stored m_qValue for non-exact nodes. Also, you can get m_game.activeArmy() to determine which side the node is on. Also, you can use m_game.lastMove().isCapture() instead of bitboard. Awesome work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need depth... I saw a piececount in bitboard.
Having a if winning/losing check would be good. We don't want to apply penalty if we're behind more than 100cp I think. But when you are black against a weak opponent you still want it...