Draft
Conversation
…scriptions. Fixes the multiplication bug induced by NMI using PPU multiplication while we do.
|
🎮 FF4 IPS Build Ready! Your patch has been built successfully! Download the IPS file from the artifacts: 📦 Artifact: The artifact will be available for 30 days. |
…g tables are not supported on the menu font.
Properly handle font changes.
…lace. Tries to make the window transformation work as expected.
…oom for the action indicator.
…ing table contains no entry return.
We can't apply it every time it's needed, if the previous char cleared the tile we currently cannot go back to the previous tile, contrary to the dialog vwf where we are more in control of string reading and it's easy to get the next char, here the chars are read by the original code and the char shifting code is injected after that part (because chars can come from various places) which means the kerning adjustment can only be done after the first letter rendering.
Only action button should be allowed on waitpad.
Centralize direct page variable definitions in vwf.s.
…select button icon.
The kerning is prevented because the previous letter cleared the tile. The proper fix would be to go back 1 tile compute the buffer pointer again and render the second char.
…ription are rendered when the player is not interacting with the items list.
Try a non-bold font for menus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.