Skip to content

Comments

add missing var for antiMeridian variable#33

Open
fknop wants to merge 1 commit intomapbox:masterfrom
fknop:patch-1
Open

add missing var for antiMeridian variable#33
fknop wants to merge 1 commit intomapbox:masterfrom
fknop:patch-1

Conversation

@fknop
Copy link

@fknop fknop commented Jul 4, 2022

Should close #32

Copy link

@dereekb dereekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw you might consider changing it to be:

    allowAntiMeridian = allowAntiMeridian || false;

    var cacheKey = tileSize + String(allowAntiMeridian);
    if (!smCache[cacheKey]) {
        smCache[cacheKey] = new SphericalMercator({ size: tileSize, antimeridian: allowAntiMeridian });
    }

That way it is in line with how they used tileSize and are setting a default value to the input variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReferenceError: antiMeridian is not defined

2 participants