Conversation
Owner
mapitman
commented
Dec 20, 2025
- Fix the makemkv installer for Ubuntu
- Make some scripts +x as well
There was a problem hiding this comment.
Pull request overview
This PR updates the Ubuntu bootstrap process by fixing the makemkv installer and introducing several new modular package installation scripts. The key improvements include updating makemkv to version 1.18.2 with the required nasm dependency, and organizing package installations into separate scripts for essential, development, desktop, media CLI, and optical disc tools.
- Updated makemkv version from 1.17.6 to 1.18.2 and added missing nasm build dependency
- Created modular package installation scripts for different use cases (essential, dev, desktop, media, optical disc)
- Added comprehensive ubuntu/bootstrap orchestration script with interactive prompts for selective installation
Reviewed changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ubuntu/install-makemkv | Updates makemkv to version 1.18.2 and adds nasm as a build dependency |
| ubuntu/install-optical-disc-packages | New script to install BluRay/DVD libraries and configure AACS decryption |
| ubuntu/install-media-cli-tools | New script to install command-line multimedia tools (ffmpeg, handbrake-cli, etc.) |
| ubuntu/install-essential-packages | New script to install core system packages and configure deb-get |
| ubuntu/install-dev-packages | New script to install development tools and libraries including GitHub CLI |
| ubuntu/install-desktop-packages | New script to install desktop applications, VS Code, and GNOME extensions |
| ubuntu/bootstrap | New orchestration script that coordinates all Ubuntu installation scripts with interactive prompts |
Make some scripts +x as well
6d89141 to
d022d05
Compare
- Switch from HTML scraping to GitHub REST API (/releases/latest endpoint) - Extract amd64 .deb URL from browser_download_url JSON field - Add .deb suffix to mktemp to ensure apt recognizes file format - Eliminates unreliable regex-based HTML parsing - Both Ubuntu 24.04 and 25.10 tests now pass cleanly with mdview installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.