Skip to content

Conversation

@mapitman
Copy link
Owner

@mapitman mapitman commented Feb 5, 2026

Summary

  • stabilize progress time formatting and freezing
  • refine rip/encode/overall progress tracking and completion messaging
  • add tests for progress display and rip summary tracking
  • apply formatting updates and ignore .cst dumps

Testing

  • dotnet test

Copilot AI review requested due to automatic review settings February 5, 2026 06:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves progress tracking and UI in the RipSharp disc ripping application. It stabilizes time formatting to always use a consistent HH:MM:SS format, adds timer freezing when tasks complete, refactors overall progress tracking with a dedicated tracker class, and adds a completion message summarizing rip results.

Changes:

  • Standardized time display format to HH:MM:SS and added timer freezing on task completion
  • Refactored overall progress tracking with new OverallProgressTracker class for cleaner code
  • Added comprehensive tests for progress display, rip summary, and overall progress tracking

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/RipSharp/Utilities/SpectreProgressDisplay.cs Standardized time format to HH:MM:SS, added _stopTime field for timer freezing, and improved value reset logic
src/RipSharp/Services/DiscRipper.cs Introduced OverallProgressTracker class, added rip completion message, and refactored progress tracking calls
src/RipSharp/MakeMkv/MakeMkvOutputHandler.cs Enhanced progress parsing to handle fraction, percentage, and byte-based progress values
src/RipSharp/Core/Program.cs Minor formatting cleanup
src/RipSharp.Tests/Utilities/SpectreProgressDisplayTests.cs New tests for time formatting, timer reset, and timer freezing
src/RipSharp.Tests/Services/DiscRipperRipSummaryTests.cs New test for rip completion message formatting
src/RipSharp.Tests/Services/DiscRipperOverallProgressTests.cs New tests for overall progress tracker behavior
src/RipSharp.Tests/Core/RipOptionsTests.cs Fixed closing braces formatting
Makefile Removed 'restore' dependency from format target
.gitignore Added *.cst files (disc structure dumps) to ignore list
.editorconfig Moved insert_final_newline to global section for consistency
.github/copilot-instructions.md New file with coding guidelines and instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mapitman mapitman merged commit caea38c into main Feb 5, 2026
7 checks passed
@mapitman mapitman deleted the fix-progressbar-resizing branch February 5, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant