This repository was archived by the owner on May 28, 2019. It is now read-only.
Refactor and remove hard-coded require('riot')#1
Open
al-the-x wants to merge 1 commit intomarcel0ll:masterfrom
Open
Refactor and remove hard-coded require('riot')#1al-the-x wants to merge 1 commit intomarcel0ll:masterfrom
require('riot')#1al-the-x wants to merge 1 commit intomarcel0ll:masterfrom
Conversation
Because I need to `require('riot/riot.csp')` for use inside a Chrome Extension instead.
Owner
|
I know I am late on this, but the preamble idea is very good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I need to
require('riot/riot.csp')for use inside a Chrome Extension instead, and if I just add theimportstatement to the<script>content of the tag,riot.compilelifts it appropriately, e.g.Compiles to:
While that means that I have to
importinside every tag, that's not a big deal to me. Maybe it could be a plugin-specific configuration option, e.g.package.riot.importof:true(default) - include standardimportpreamblefalse- don't include ANY preamble'string'- include preamble asimport riot from 'string'Thoughts?