Skip to content

Conversation

@ivannunyadambiz
Copy link

added arguments for voltage and current, removed required=True for the group (this lets you change the current or voltage without any other action), fixed help message for info argument

added arguments for voltage and current, removed required=True for the group (this lets you change the current or voltage without any other action), fixed help message for info argument
@marcj71
Copy link
Owner

marcj71 commented Oct 13, 2024

Thanks Ivan! The code in 'if name == main' was really only intended as an example, since the functions are usually called from an testing & logging script.
I suggest to only print the message in set_voltage_and_current() when args.verbose == True, and to call the function as ps.set... . If you change that, I'll gladly accept your improvement :)

don't take this as my final commit. i'm going to have another go at this tomorrow when i'm in the office. I think I found a possible problem or two elsewhere and would like to test and if required, fix it
Copy link
Author

@ivannunyadambiz ivannunyadambiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a go at it with the supply, and it seems to be doing what it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants