fix: Ensure infinite scroll properly loads more climb results #359
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
marcodejongh
commented
Dec 25, 2025
marcodejongh
commented
- Convert hasMoreResults to always return a boolean instead of potentially undefined, which could cause InfiniteScroll's hasMore prop to behave incorrectly
- Return the Promise from setSize in fetchMoreClimbs to allow proper coordination with the InfiniteScroll component
- Update fetchMoreClimbs type signature to reflect Promise return
- Convert hasMoreResults to always return a boolean instead of potentially undefined, which could cause InfiniteScroll's hasMore prop to behave incorrectly - Return the Promise from setSize in fetchMoreClimbs to allow proper coordination with the InfiniteScroll component - Update fetchMoreClimbs type signature to reflect Promise return
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.