fix: Default hasMoreResults to true until data is loaded #364
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The infinite scroll trigger was broken because hasMoreResults returned undefined (falsy) when SWR data hadn't loaded yet. This prevented the InfiniteScroll component from triggering the next fetch. Now hasMoreResults defaults to true while isFetchingClimbs is true (so infinite scroll works during SSR hydration), and false after loading completes with no data.
marcodejongh
force-pushed
the
claude/fix-climb-list-scroll-750A8
branch
from
1720e08 to
4937cba
Compare
The CSS rule setting overflow-x: hidden on .ant-layout-content was interfering with the scroll detection for react-infinite-scroll-component. The scroll container (#content-for-scrollable) has its overflow properties set via inline styles, which should be the source of truth. Removing this CSS rule allows the InfiniteScroll component to properly detect scroll events and trigger loading more climbs.
Add useEffect to manually trigger fetchMoreClimbs when the initial content doesn't fill the scroll container. This handles the case where react-infinite-scroll-component's auto-detection doesn't work properly because there's no scrollbar to trigger scroll events.
Uses a ref to track when fetching completes, then checks if the scroll container needs more content. This avoids timeouts and only triggers after each fetch completes or on initial mount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infinite scroll trigger was broken because hasMoreResults returned
undefined (falsy) when SWR data hadn't loaded yet. This prevented the
InfiniteScroll component from triggering the next fetch.
When using SSR initialClimbs, the client-side SWR fetch hasn't completed
yet, so hasMoreResults was undefined. Now it defaults to true until
we have actual data to determine the correct value.