Skip to content

Remove deprecation showing up in conjunction with jquery.migrate #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fefoweb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecation showing up in conjunction with jquery.migrate #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# System files
.DS_Store
.idea

# Node modules
node_modules
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 2.4.2
- remove deprecation showing up in conjunction with jquery.migrate
* JQMIGRATE: jQuery.fn.scroll() event shorthand is deprecated
* JQMIGRATE: jQuery.fn.click() event shorthand is deprecated

## 2.4.1
- Update jQuery dependency

Expand Down
6 changes: 3 additions & 3 deletions dist/jquery.scrollUp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* scrollup v2.4.1
* scrollup v2.4.2
* Url: http://markgoodyear.com/labs/scrollup/
* Copyright (c) Mark Goodyear — @markgdyr — http://markgoodyear.com
* License: MIT
Expand Down Expand Up @@ -95,7 +95,7 @@
}

// Scroll function
scrollEvent = $(window).scroll(function () {
scrollEvent = $(window).on('scroll', function () {
if ($(window).scrollTop() > scrollDis) {
if (!triggerVisible) {
$self[animIn](animSpeed);
Expand All @@ -120,7 +120,7 @@
}

// To the top
$self.click(function (e) {
$self.on('click', function (e) {
e.preventDefault();

$('html, body').animate({
Expand Down
4 changes: 2 additions & 2 deletions dist/jquery.scrollUp.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "scrollup",
"title": "scrollUp",
"description": "A jQuery plugin to create a customisable 'Scroll to top' feature that will work with any website, with ease.",
"version": "2.4.1",
"version": "2.4.2",
"homepage": "http://markgoodyear.com/labs/scrollup/",
"author": {
"name": "Mark Goodyear",
Expand Down
4 changes: 2 additions & 2 deletions src/jquery.scrollUp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
}

// Scroll function
scrollEvent = $(window).scroll(function () {
scrollEvent = $(window).on('scroll', function () {
if ($(window).scrollTop() > scrollDis) {
if (!triggerVisible) {
$self[animIn](animSpeed);
Expand All @@ -114,7 +114,7 @@
}

// To the top
$self.click(function (e) {
$self.on('click', function (e) {
e.preventDefault();

$('html, body').animate({
Expand Down