subset that returns a BISM when appropriate#256
Merged
Conversation
Closed
Collaborator
|
NB: there are tests for for subsetting a BISM and for BISM subset replacement. |
Collaborator
|
@josherrickson I've requested your review mostly as fyi; a glance may be all this calls for. (I would have requested @kkbrum's review in the same spirit had it let me.) |
Collaborator
|
Thanks, @josherrickson. Many of the changes in this #246 workstream were merged into master earlier; this compare view gives a fuller sense of them. @nullsatz was going to look into another minor issue (briefly described here) before wrapping the work up. |
Collaborator
Author
|
I have pushed a commit with the discussed changes. Here are the results of some efficiency testing in preperation for the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work in this branch is to support returning a BISM from a subset operation when input and conditions allow.