Skip to content

Conversation

@friemt
Copy link
Contributor

@friemt friemt commented Dec 24, 2024

php8.4 deprecated implicit nullable parameters. This PR updates function signatures to include ?-type where necessary.

This change should not affect anything since the implementations already accounted for the parameters to be null, only the correct type-hint was missing, which is a feature introduced in php7.1.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12484812220

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.755%

Totals Coverage Status
Change from base Build 6133616751: 0.0%
Covered Lines: 813
Relevant Lines: 815

💛 - Coveralls

@markrogoyski markrogoyski changed the base branch from main to develop January 14, 2025 06:01
@markrogoyski
Copy link
Owner

Hi @friemt,

Thanks for your interest in IterTools-PHP and thanks for the changes to for PHP 8.4 compatibility. Apologies in the delay in getting to this. These updates will go in the next release.

Thanks again!
Mark

@markrogoyski markrogoyski merged commit 0ba0fcf into markrogoyski:develop Jan 29, 2025
1 of 5 checks passed
@friemt friemt deleted the php84-nullable-deprecation branch January 31, 2025 19:52
@AndreasA
Copy link

Hi @markrogoyski Just wondering if you have a timeframe regarding the next release that will include this deprecation fix

@markrogoyski
Copy link
Owner

Sorry for the delay. I'll get to it this week.

@markrogoyski
Copy link
Owner

This has been released in the latest version, v1.9.0. Sorry for the delay and getting this out.

@friemt
Copy link
Contributor Author

friemt commented Feb 24, 2025

Hey, no problem. Thanks for accepting the PR and pushing out a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants