Showing targetViewController in the preview instead of screenshot#13
Open
hansstefan wants to merge 5 commits intomarmelroy:masterfrom
Open
Showing targetViewController in the preview instead of screenshot#13hansstefan wants to merge 5 commits intomarmelroy:masterfrom
hansstefan wants to merge 5 commits intomarmelroy:masterfrom
Conversation
…iew) just before commiting PeekPop (to have better transition animation)
hansstefan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added activity indicator to PreviewViewController to compare 3dTouch PeekPop with the simulated one.
This pull request is showing actual targetViewController in the preview, creating a screenshot at the very end: just before commiting PeekPop.
connected issue:
#12