Update to Swift 3.0, changed screenshot to viewController and lower pressure requirements#32
Open
piotrtorczynski wants to merge 9 commits intomarmelroy:masterfrom
Open
Update to Swift 3.0, changed screenshot to viewController and lower pressure requirements#32piotrtorczynski wants to merge 9 commits intomarmelroy:masterfrom
piotrtorczynski wants to merge 9 commits intomarmelroy:masterfrom
Conversation
…legate naming convention to swift 3
# Conflicts: # PeekPop.podspec # PeekPop/Info.plist # PeekPop/PeekPop.swift # PeekPop/PeekPopGestureRecognizer.swift # PeekPop/PeekPopManager.swift # PeekPop/PeekPopView.swift # PeekPopTests/Info.plist # examples/InstaPreview/Sample/ImagesCollectionViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to show you some changes in code. I was working with your library and it's fantastic, but also have some drawback.
I implemented showing viewController instead of view's screenshot to let me show viewController and it's loading action. Without this I had barely few things loaded then.
I changed the name of delegate method to suit Swift API guideline.
I saw that in normal cases the gesture you have to make to call commit action is like lying your finger on the screen, so I wanted to lower this requirement and make magic numbers smaller.
It would be nice if you could answer my questions somehow. :)
Great job 👍