-
Notifications
You must be signed in to change notification settings - Fork 0
Update semantic colors with intention system and quaternary colors #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe PR extends the SemanticColors theme system with new alpha color variants, introduces intention-based color fields (info, success, warning, error with background and content pairs), and removes deprecated border color placeholders. It updates dependent code and tests accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Coverage: 99.62% → 99.63% (+0.01%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@test/theme/semantic_colors_test.dart`:
- Around line 265-285: Tests for SemanticColors.copyWith and SemanticColors.lerp
are missing assertions for the newly added quaternary intention tokens; update
the tests that reference SemanticColors.light.copyWith and the
SemanticColors.lerp tests to include assertions for the quaternary fields (e.g.
intentionInfoQuaternaryBackground, intentionInfoQuaternaryContent,
intentionSuccessQuaternaryBackground, intentionSuccessQuaternaryContent,
intentionWarningQuaternaryBackground, intentionWarningQuaternaryContent,
intentionErrorQuaternaryBackground, intentionErrorQuaternaryContent) so the
copyWith returns the new values and lerp interpolates them as expected.
e498621 to
2f77475
Compare
✅ Coverage: 99.62% → 99.63% (+0.01%) |
- Add new intention colors (info, success, warning, error) with background/content variants - Replace borderInfo/borderSuccess/borderWarning with intention color system - Add backgroundContentQuaternary and fillQuaternary color properties - Add alpha transparency primitives (BlackAlpha, WhiteAlpha) - Swap destructive color hierarchy (red600 primary, red500 secondary) - Add missing primitive colors (red50/950, green50/600/950, blue600, orange600) - Update wn_relay_tile to use intentionSuccessContent Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2f77475 to
8701954
Compare
✅ Coverage: 99.62% → 99.63% (+0.01%) |
josefinalliende
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.