Skip to content

Conversation

@erskingardner
Copy link
Member

@erskingardner erskingardner commented Jan 23, 2026

Summary

  • Add new intention colors (info, success, warning, error) with background/content variants replacing borderInfo/borderSuccess/borderWarning
  • Add backgroundContentQuaternary and fillQuaternary color properties with alpha transparency primitives
  • Swap destructive color hierarchy (red600 is now primary, red500 is secondary)
  • Add missing primitive colors (red50/950, green50/600/950, blue600, orange600)

Test plan

  • All semantic colors tests pass (29 tests)
  • All relay tile tests pass (12 tests)
  • Flutter analyzer passes with no issues
  • Pre-commit checks pass (formatting, linting, all tests)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added intention-based color system with support for info, success, warning, and error states, each with background and content color variants.
    • Introduced new fill color variants (quaternary) for enhanced design system flexibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Warning

Rate limit exceeded

@erskingardner has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

The PR extends the SemanticColors theme system with new alpha color variants, introduces intention-based color fields (info, success, warning, error with background and content pairs), and removes deprecated border color placeholders. It updates dependent code and tests accordingly.

Changes

Cohort / File(s) Summary
Core semantic colors
lib/theme/semantic_colors.dart
Added 13 new public color fields (backgroundContentQuaternary, fillQuaternary variants, 8 intention colors). Removed 3 deprecated border fields. Introduced _BlackAlphaColors and _WhiteAlphaColors token groups with opacity variants. Updated Light/Dark theme initializers, copyWith, and lerp methods to handle new fields.
Widget and test updates
lib/widgets/wn_relay_tile.dart, test/widgets/wn_relay_tile_test.dart
Updated status indicator color from borderSuccess to intentionSuccessContent in widget and corresponding test expectations.
Theme test coverage
test/theme/semantic_colors_test.dart
Extended copyWith and lerp test cases to validate all 8 new intention color fields, replacing expectations for removed border fields.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • josefinalliende
  • untreu2
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main changes: introduction of an intention color system (info, success, warning, error) and quaternary color properties, which are the primary modifications across the semantic colors file and related code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

✅ Coverage: 99.62% → 99.63% (+0.01%)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@test/theme/semantic_colors_test.dart`:
- Around line 265-285: Tests for SemanticColors.copyWith and SemanticColors.lerp
are missing assertions for the newly added quaternary intention tokens; update
the tests that reference SemanticColors.light.copyWith and the
SemanticColors.lerp tests to include assertions for the quaternary fields (e.g.
intentionInfoQuaternaryBackground, intentionInfoQuaternaryContent,
intentionSuccessQuaternaryBackground, intentionSuccessQuaternaryContent,
intentionWarningQuaternaryBackground, intentionWarningQuaternaryContent,
intentionErrorQuaternaryBackground, intentionErrorQuaternaryContent) so the
copyWith returns the new values and lerp interpolates them as expected.

@github-actions
Copy link

✅ Coverage: 99.62% → 99.63% (+0.01%)

- Add new intention colors (info, success, warning, error) with background/content variants
- Replace borderInfo/borderSuccess/borderWarning with intention color system
- Add backgroundContentQuaternary and fillQuaternary color properties
- Add alpha transparency primitives (BlackAlpha, WhiteAlpha)
- Swap destructive color hierarchy (red600 primary, red500 secondary)
- Add missing primitive colors (red50/950, green50/600/950, blue600, orange600)
- Update wn_relay_tile to use intentionSuccessContent

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

✅ Coverage: 99.62% → 99.63% (+0.01%)

Copy link
Collaborator

@josefinalliende josefinalliende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

@erskingardner erskingardner merged commit 157ae4e into master Jan 23, 2026
4 checks passed
@erskingardner erskingardner deleted the chore/update-colors branch January 23, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants