-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/emoji picker #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis PR replaces the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Coverage: 99.6% → 97.85% (-1.75%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@lib/screens/message_actions_screen.dart`:
- Around line 64-118: The Delete button is currently shown for own messages even
when the optional onDelete callback is null; update the prop passed to
MessageActionsModal so onDelete is only provided when both isOwnMessage and
onDelete != null (i.e., change the onDelete argument from onDelete: isOwnMessage
? handleDelete : null to onDelete: (isOwnMessage && onDelete != null) ?
handleDelete : null) so the modal only renders a delete action when a real
handler exists; ensure references are to the existing handleDelete function and
the MessageActionsModal's onDelete prop.
Description
Type of Change
Checklist
just precommitto ensure that formatting and linting are correctCHANGELOG.mdfile with your changes (if they affect the user experience)Summary by CodeRabbit
New Features
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.