Validate disk removals (Test) #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding unit tests for blockdevice validations' Update method. The change requires very basic fake implementation of the cache objects used. Also pipeline has additional step and very basic go test which can be further optimized to output the coverage in file. Signed-off-by: Martin Dekov <martin.dekov@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit tests for blockdevice validations' Update
method. The change requires very basic fake implementation
of the cache objects used.
Also pipeline has additional step and very basic go test
which can be further optimized to output the coverage
in file.
Problem:
Repo does not provide a way to unit test code easily
Solution:
This change adds fakes for base objects and adds unit test scenarios for change:
harvester#248
Related Issue:
Unit test part of PR: harvester#248
For issue: harvester/harvester#3344
Test plan:
Unit tests