Skip to content

Conversation

@google-labs-jules
Copy link

Added support for AES based Delegated Management (DM) tokens.

Changes:

  • library/src/main/java/pro/javacard/gp/DMTokenizer.java: Added AESTokenizer class and forAESKey factory method. It uses GPCrypto.aes_cmac to generate an 8-byte token.
  • tool/src/main/java/pro/javacard/gptool/GPTool.java: Updated OPT_DM_KEY handling to detect and use AES keys (via SecretKey) for token generation.

Verified with a standalone test script (not included) that the generated token is a valid AES-CMAC of the data.


PR created automatically by Jules for task 13992379223839198692 started by @martinpaljak

- Add `AESTokenizer` to `DMTokenizer.java` to support AES-CMAC tokens.
- Update `GPTool.java` to support AES keys for `--dm-key`.
- This enables Delegated Management using AES keys as per GlobalPlatform 2.3.1.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant