Fix division by zero in calculateResizeRatio causing NaN ratios#5
Closed
Fix division by zero in calculateResizeRatio causing NaN ratios#5
Conversation
When the container is resized to very small dimensions (or zero), the totalWidth or totalHeight could be zero, causing division by zero and resulting in NaN ratio values. This would break the entire layout. Added guard clauses to return the clamped ratio early when totalWidth or totalHeight is zero or negative, preventing NaN propagation.
|
No issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the container is resized to very small dimensions (or zero), the
totalWidth or totalHeight could be zero, causing division by zero and
resulting in NaN ratio values. This would break the entire layout.
Added guard clauses to return the clamped ratio early when totalWidth
or totalHeight is zero or negative, preventing NaN propagation.