Skip to content

Conversation

@jcbaillie
Copy link
Contributor

No description provided.

@jcbaillie jcbaillie requested a review from qdrn July 11, 2023 10:19
*give ref to github implementation, and explain again how to build and deploy*

# Register a new account
*provide command line instructions on how to interact with the above sc*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to do it with massa-web3 (node).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It applies also to everything below.

bought and sold in bulks. They have a known price then, which is the price at which the last transaction
took place.

# Create a new Fungible Token smart contract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Create a new Fungible Token smart contract
## Create a new Fungible Token smart contract

# Create a new Fungible Token smart contract
*give ref to github implementation, and explain again how to build and deploy*

# Register a new account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Register a new account
## Register a new account

# Register a new account
*provide command line instructions on how to interact with the above sc*

# Check balance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check balance
## Check balance

# Check balance
*provide cli + explanations*

# Transfering tokens between accounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Transfering tokens between accounts
## Transfering tokens between accounts

url="./fungible-token"
title="Fungible Token"
content="Create a fungible token."
icon="🤖"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use different icons.

url="./non-fungible-token"
title="Non Fungible Token"
content="Create a non fungible token."
icon="🤖"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@qdrn qdrn mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants