Open
Conversation
Co-authored-by: Arthur Baghdasaryan <62405127+arthurbaghdas@users.noreply.github.com>
#2037) * Only generate linkContext when item.label exists * requested changes * Update contact-item.twig * Update contact-item.twig * Update contact-item.twig --------- Co-authored-by: Minghua Sun <clairesunstudio@gmail.com>
…h-video (#2045) * initial approach * second approach * Create DP-44710.yml
* add loader lottie to assets package * add changelog
* fix patternlab backstop fails on develop * remove obsolete files
* adding tokens css variables for MDS * added changelog * updated changelog to better fit template * renamed css folder to css * added new line at end of changelog file * added second new line to match other changelogs * Update packages/tokens/README.md Co-authored-by: Thomas Fleming <thomas.r.fleming@mass.gov> * Update packages/tokens/README.md Co-authored-by: Thomas Fleming <thomas.r.fleming@mass.gov> --------- Co-authored-by: Thomas Fleming <thomas.r.fleming@mass.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added:
Add css variables for tokens to Mayflower repo ( #2049 )
Add loader animation lottie file to assets. ( #2046 )
Fixed:
Fix Patternlab Backstop ( #2048 )
Fix heading level skip accessibility issue on promo page section videos without titles by using H2 instead of H3 to maintain proper heading hierarchy ( #2045 )
Fix accessibility issue where aria-describedby attribute referenced non-existent IDs on address directions links. The linkContext ID is now only generated and passed to decorative-link when a label element exists, preventing invalid aria-describedby attributes. ( #2037 )
Conditionally render bio link section only when person.bio is defined and has a valid href, preventing empty anchor tags from appearing in the rendered HTML. ( #2038 )