DP-44225 Add-field-to-Document-media-entity-for-authors-to-select-accessibility-state-designation#3231
Draft
dstorozhuk wants to merge 23 commits intodevelopfrom
Conversation
…widget and storage configuration Introduced `field_accessibility_status` to the `Document` media entity with a custom `list_long_label` field type and widget for detailed accessibility designations. Updated form and view displays to support the new field and adjusted configurations accordingly. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…moval Added JavaScript behavior to reset the `Self-Reported Accessibility Status` field to `_none` when a file is removed. Updated widget implementation and libraries configuration accordingly. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
dstorozhuk
force-pushed
the
feature/DP-44225-Add-field-to-Document-media-entity-for-authors-to-select-accessibility-state-designation
branch
from
8443791 to
0e08c52
Compare
…_self_rpt` and update related configurations Replaced `field_accessibility_status` with `field_accessibility_self_rpt` across media entity configurations, forms, view displays, and field types. Adjusted allowed HTML tags and improved widget labels for accessibility status designation. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
dstorozhuk
force-pushed
the
feature/DP-44225-Add-field-to-Document-media-entity-for-authors-to-select-accessibility-state-designation
branch
from
0e08c52 to
7d80cc3
Compare
Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…enaming Revised JavaScript to replace `field_accessibility_status` with `field_accessibility_self_rpt` for consistency with renamed field. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…dia-entity-for-authors-to-select-accessibility-state-designation
…dia-entity-for-authors-to-select-accessibility-state-designation
…dia-entity-for-authors-to-select-accessibility-state-designation * develop: DP-44947: Disable jQuery modules on prod (#3256) DP-41803: A11Y datatable uses duplicate table tag (#3243) changelog update and remove old changelog files DP-44710-Heading-level-skipped-accessibility-error-on-promo-pages-with-video (#3247)
- Set field_accessibility_self_rpt to required: true in config - Fix widget to safely handle _none option (use isset instead of array_shift) - Set default_value to NULL when field is required (no empty option) - Simplify JS reset to just uncheck all radios (no _none to select) The TBD option was rendered via getEmptyLabel() which only shows when the field is not required. Making it required eliminates the empty choice. Existing documents with no value will need authors to select a status when resaving.
…et logic - Set `field_accessibility_self_rpt` to `required: false` in configuration. - Updated JS to hide and reset the `_none` (TBD) option on file changes. - Improved reset behavior to handle file uploads, removals, and AJAX updates effectively. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
- Inject an aria-live region for screen readers to announce resets. - Update JavaScript to notify users when the field is reset to an empty state. - Enhance accessibility and usability for screen reader users. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…dia-entity-for-authors-to-select-accessibility-state-designation
- Extend `noneSelector` to handle multiple naming patterns for `_none` options. - Ensure compatibility for accessibility status reset in Document media entities. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…dia-entity-for-authors-to-select-accessibility-state-designation
Contributor
|
Moved to draft since communication plan will be needed prior to release. Ok to code review but hold merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Explain the technical implementation of the work done.
Jira: (Skip unless you are MA staff)
DP-****
To Test:
Peer Review Checklist